Skip to content

bcdb_mock: make the mock is the same data types as the production bcdb #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 28, 2019
Merged

bcdb_mock: make the mock is the same data types as the production bcdb #336

merged 18 commits into from
Oct 28, 2019

Conversation

@zaibon
Copy link
Contributor

@zaibon zaibon commented Oct 18, 2019

fixes #327

@zaibon zaibon mentioned this pull request Oct 18, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 21, 2019 •
edited
Loading

Codecov Report

Merging #336 into master will decrease coverage by 0.13%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   39.31%   39.17%   -0.14%     
==========================================
  Files          57       58       +1     
  Lines        3597     3602       +5     
==========================================
- Hits         1414     1411       -3     
- Misses       1990     1999       +9     
+ Partials      193      192       -1
Impacted Files Coverage Δ
pkg/kernel/kernel.go 73.91% <ø> (ø) ⬆️
pkg/provision/network.go 60% <ø> (-1.3%) ⬇️
pkg/gedis/commands_capacity.go 0% <0%> (ø)
pkg/provision/engine.go 0% <0%> (ø) ⬆️
pkg/identity/store.go 0% <0%> (ø) ⬆️
pkg/gedis/commands_identity.go 64.18% <100%> (+0.96%) ⬆️
pkg/environment/environment.go 71.42% <71.42%> (-2.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24deff0...626806e. Read the comment docs.

muhamadazmy
muhamadazmy approved these changes Oct 23, 2019
View reviewed changes
cmds/identityd/main.go
version.ShowAndExit(false)
}

if err := os.MkdirAll(root, 0750); err != nil {
Copy link
Member

@muhamadazmy muhamadazmy Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identityd failed to start on a clean disk, so this was needed

zaibon
zaibon commented Oct 28, 2019
View reviewed changes
tools/bcdb_mock/tnodb_test.go Outdated
"fmt"
"net"
"testing"
// import (
Copy link
Contributor Author

@zaibon zaibon Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this file too.

@zaibon zaibon marked this pull request as ready for review October 28, 2019 10:03
@zaibon zaibon merged commit a06b2c2 into master Oct 28, 2019
@zaibon zaibon deleted the mock_types branch October 28, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muhamadazmy muhamadazmy muhamadazmy approved these changes

@delandtj delandtj Awaiting requested review from delandtj

@LeeSmet LeeSmet Awaiting requested review from LeeSmet

@maxux maxux Awaiting requested review from maxux

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bring bcdb mock to same data interface as gedis client

3 participants

@zaibon @muhamadazmy