contd: remove coreX chroot hack #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #381 Now that we have coreX build staticly, we can just mount the binary into the container. We don't need to do the chroot hack
zaibon
force-pushed
the
corex_volumes
branch
from
e3733a2 to
611af9c
Compare
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 40.82% 40.96% +0.13%
==========================================
Files 62 62
Lines 3868 3850 -18
==========================================
- Hits 1579 1577 -2
+ Misses 2077 2061 -16
Partials 212 212
Continue to review full report at Codecov.
|
muhamadazmy
approved these changes
Nov 15, 2019
Member
muhamadazmy
left a comment
muhamadazmy
left a comment
There was a problem hiding this comment.
LGTM, only 1 minor comment
| type MountInfo struct { | ||
| Source string // source of the mount point on the host | ||
| Target string // target of mount inside the container | ||
| Type string // mount type |
| for _, linxNS := range spec.Linux.Namespaces { | ||
| log.Info().Msgf("namespace %+v", linxNS.Type) | ||
| } | ||
| log.Info().Msgf("mounts %+v", spec.Mounts) |
Member
There was a problem hiding this comment.
I think this should be Debug() not info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #381
Now that we have coreX build staticly, we can just mount the binary into
the container. We don't need to do the chroot hack
Let's wait we have a new base image with static coreX binary before merging this.