send logs of the node with pubkey instead of accountid #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashraf Fouda <ashraf.m.fouda@gmail.com>
ashraffouda
requested review from
Eslam-Nawara,
Omarabdul3ziz,
muhamadazmy,
rawdaGastan and
xmonader
as code owners
xmonader
approved these changes
Mar 27, 2025
xmonader
reviewed
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we send logs to loki with node id which is now not available in zos4 unless someone gets it from the node it self with
idenittyd -idcommand since we now uses pubkey as the id of the node it can be uses as a key for loki to identitfy the node#14