This repository was archived by the owner on Aug 12, 2025. It is now read-only.
Merged
Conversation
- purged PeerVerifier, StorbRecord, and StorbStore
- updated MetadataDB implementation to incorporate correct type conversions when inserting and querying to and from database - added newtype for DateTime<Utc> (SqlDateTime) as part of the above change, and also TryForm for PieceType - added command channel and handling to MetadataDB - added tests for MetadataDB - removed dht_dir param from settings.toml.example
- removed infohash, chunk, and piece insertion helpers - using r2d2 to create connection pools to manage db connections - refactored all insertion and query functions to be run through sender channels as `MetadataDBCommand`s - refactored metadatdb insertion and query handler functions to be async - updated metadatadb tests
- mostly purged dht stuff from all upload-related routines - updated the upload processes in `upload.rs` - incorporated metadatadb. - enhanced error handling and logging for database operations. - updated metadatadb schema - removed redundant columns from certain tables. - improved object metadata insertion logic. - modified the `Validator` struct to include a sender for the metadata database. - adjusted the `run_synthetic_challenges` method to utilize the new metadata database for chunk and piece retrieval. - updated `MinerState` to have an `Arc` miner only - the miner itself is no longer the critical sections for locks, but rather certain resources inside of the `Miner` (much like how components related to the validator are written to reduce blocking). - updated validator docs - downloading is temporarily disabled on the validator (to be addressed in upcoming commits).
- incorporated metadatadb into download routines - added filenames to infohash tracker entries - fixed issue with chunks and pieces being gathered out-of-order during uploads - addressed some clippy warnings
- added checks to prevent uploading a piece if it already exists in the network - fixed typos of metadata db sender variables - added `get_piece` function to metadatadb w/ accompanying tests - removed duplicate score attempt and success updating in store challenges
rishiad
commented
Jun 2, 2025
rayokamoto
suggested changes
Jun 2, 2025
Contributor
rayokamoto
left a comment
rayokamoto
left a comment
There was a problem hiding this comment.
Another thing - I'm not the biggest fan of putting [u8; 32] everywhere for infohashes and piece hashes. Could we make types for these?
- removed some useless comments - update vali docs
rayokamoto
suggested changes
Jun 3, 2025
Contributor
rayokamoto
left a comment
rayokamoto
left a comment
There was a problem hiding this comment.
Please address the u8 slices not having types as well
rayokamoto
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stake guarded metadata database with CRDT to replace current DHT metadata system
TO-DO