Dapp ropsten deployment by r-czajkowski · Pull Request #1441 · threshold-network/keep-core

r-czajkowski · 2020-03-10T17:54:14Z

Depends on: #1438
Closes: #1400

New configs are deployed to keep-dev, available @ http://keep-dapp-token-dashboard.default.svc.cluster.local/ (behind the VPN)

sthompson22 · 2020-03-10T18:02:45Z

contracts/solidity/dashboard/.env.keep-dev

@@ -1 +1,2 @@
-REACT_APP_ETH_NETWORK_WEB_SOCKET_ADDRESS=ws://eth-tx-node.default.svc.cluster.local:8546
+REACT_APP_ETH_NETWORK_WEB_SOCKET_ADDRESS=ws://eth-tx-node.default.svc.cluster.local:8546


Should this filename match the truffle network name?

Yep exactly. Good catch. The main idea is to keep consistent with the keep-dev and keep-test. What do you think about this? Or maybe we should create a new environment variable dedicated to the dapp?

sthompson22 · 2020-03-10T18:03:42Z

contracts/solidity/dashboard/.env.keep-dev

@@ -1 +1,2 @@
-REACT_APP_ETH_NETWORK_WEB_SOCKET_ADDRESS=ws://eth-tx-node.default.svc.cluster.local:8546
+REACT_APP_ETH_NETWORK_WEB_SOCKET_ADDRESS=ws://eth-tx-node.default.svc.cluster.local:8546
+REACT_APP_ETHERSCAN_DEFAULT_URL='https://etherscan.io/address/'


This won't play nicely against the private network.

Fine that it's here, just wanted to call it out.

Possibly leave a comment.

sthompson22

We're going to need additional configuration on the Kube side since we'll be exposing the Ropsten instance to the internet. Specifically an Ingress and Service with type NodePort. Do you want to do that, or should I pick that up in this PR?

sthompson22 · 2020-03-11T13:11:52Z

Another thought - should we rename staking-dapp to token-dapp everywhere? I think staking is too narrow?

r-czajkowski · 2020-03-11T13:56:26Z

Another thought - should we rename staking-dapp to token-dapp everywhere? I think staking is too narrow?

Agree. I thought about it. I'll update also in the circleci config.

r-czajkowski · 2020-03-11T16:55:34Z

@sthompson22, token-dashboard-dapp will be ok? Or would you prefer a shortened version token-dapp?

sthompson22 · 2020-03-11T18:35:39Z

token-dashboard-dapp will be ok? Or would you prefer a shortened version token-dapp

Thanks for asking, right now it's keep-dapp-staking everywhere. I think keep-dapp-token-dashboard sounds better.

Evnets subscirpiton works well without the websocket provider

.env files are not needed anymore. The default ehterscan address can be returned from the custom funcion.

sthompson22 · 2020-03-12T14:00:59Z

Thanks for going through these updates. I'm going to take it for a spin in keep-dev now.

sthompson22 · 2020-03-12T14:13:05Z

To give a bit of color on my naming recommendation in the last comment keep-dapp-token-dashboard

This allows us to be consistent around the naming pattern prefix project-thing-function, easier to parse files, and allows a label scheme that matches such as:

app: keep-dapp
type: keep-token-dashboard

Not super relevant now but say we create some new dapp for Keep, we call it "operations" in this example. Using the format above that would give us:

keep-dapp-operations

app: keep-dapp
type: operations

Benefit here is that it binds deployed applications that are of the same breed, sort of like labeling "frontend" and "backend", in a more specific way. Anywho I'm not firm on this, just wanted to explain my thought process on the original suggestion.

Just fine with it as-is

r-czajkowski · 2020-03-12T14:20:02Z

ah right Sloan. I missed it. I'll update

We've removed all of the .env files, so there's nothing to copy anymore.

sthompson22 · 2020-03-12T18:14:44Z

I had to do some surgery to get a keep-dev deployment without contract migrations happening in the same build (e.g. if contracts you want to use are already migrated). That was done #1454 here.

To get this out to Ropsten, if it's not coupled with a contract deployment we'll need to do something similar.

sthompson22 · 2020-03-12T18:39:10Z

@nkuba @r-czajkowski Thanks again ya'll for getting this put together. I've run through a deployment to keep-dev, and as a result pushed one small change here. Kuba if you want to do the honors of merging?

nkuba · 2020-03-13T08:59:15Z

contracts/solidity/dashboard/src/constants/constants.js

-export const OPERATOR_CONTRACT_NAME_EVENTS = 'eventKeepRandomBeaconOperatorContract'
-
-export const ETHERSCAN_DEFAULT_URL = 'https://etherscan.io/address/'
+export const ETHERSCAN_DEFAULT_URL = 'https://ropsten.etherscan.io/address/'


Please remember about handling it per environment in a follow-up PR.

r-czajkowski added 7 commits March 10, 2020 16:04

Add a new env file for ropsten deployment

15e91c8

Set a default etherscane url in env file

d2d9fe8

Fix eslint trailing spaces error

eee9636

Update ropsten etherscan url

3690600

Add dapp deployment files to the keep-test context

de6a7c3

Leave one script in package.json to build dapp

148bf84

Update the build command in the Dockerfile- dapp

01fb108

r-czajkowski requested review from nkuba and sthompson22 March 10, 2020 17:54

r-czajkowski changed the base branch from master to tokens-page-grantee March 10, 2020 17:54

Restore npm run setup in a start script- dapp

b6128ea

sthompson22 reviewed Mar 10, 2020

View reviewed changes

Rename the .env file for keep dev deployment

47099cb

pdyraga added the ☁️ infrastructure label Mar 10, 2020

r-czajkowski added 2 commits March 11, 2020 13:18

Add an Ingress cfg- dapp

c3fc4e4

Update Service config- dapp

d5c27f3

r-czajkowski added 2 commits March 12, 2020 10:14

Rename staking-dapp to token-dashboard-dapp

26a2e5d

Update the metadata name in deployment cfg- dapp

98e5a98

r-czajkowski marked this pull request as ready for review March 12, 2020 10:42

r-czajkowski changed the base branch from tokens-page-grantee to master March 12, 2020 13:33

r-czajkowski added 4 commits March 12, 2020 14:33

Merge branch master

8d49112

Remove unused the OverviewTab component

933b908

Resignation from unnecessary web3 socket provider

bde03b0

Evnets subscirpiton works well without the websocket provider

Remove unnecessary .env file- dapp

d0d1df5

.env files are not needed anymore. The default ehterscan address can be returned from the custom funcion.

r-czajkowski added 3 commits March 12, 2020 15:01

Opt-out of passing build-arg to a dapp Dockerfile

fcf5901

Update the build command in Dockerfile- dapp

06445b7

Add a slash at the end of the etherscan url

bde6529

r-czajkowski and others added 2 commits March 12, 2020 15:34

Keep consistency around the naming pattern prefix

d844872

Remove .env* copy during build

80e211d

We've removed all of the .env files, so there's nothing to copy anymore.

nkuba approved these changes Mar 13, 2020

View reviewed changes

nkuba merged commit 6e99790 into master Mar 13, 2020

nkuba deleted the dapp-ropsten-deployment branch March 13, 2020 09:00

		@@ -1 +1,2 @@
		REACT_APP_ETH_NETWORK_WEB_SOCKET_ADDRESS=ws://eth-tx-node.default.svc.cluster.local:8546 No newline at end of file
		REACT_APP_ETH_NETWORK_WEB_SOCKET_ADDRESS=ws://eth-tx-node.default.svc.cluster.local:8546

Conversation

r-czajkowski commented Mar 10, 2020 • edited by sthompson22 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sthompson22 Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

r-czajkowski Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

sthompson22 Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

sthompson22 Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

sthompson22 Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

sthompson22 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sthompson22 commented Mar 11, 2020

Uh oh!

r-czajkowski commented Mar 11, 2020

Uh oh!

r-czajkowski commented Mar 11, 2020

Uh oh!

sthompson22 commented Mar 11, 2020

Uh oh!

sthompson22 commented Mar 12, 2020

Uh oh!

sthompson22 commented Mar 12, 2020

Uh oh!

r-czajkowski commented Mar 12, 2020

Uh oh!

sthompson22 commented Mar 12, 2020

Uh oh!

sthompson22 commented Mar 12, 2020

Uh oh!

nkuba Mar 13, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

r-czajkowski commented Mar 10, 2020 •

edited by sthompson22

Loading

sthompson22 left a comment •

edited

Loading