Adding signature safety margin on DKG result#1603
Merged
Conversation
dimpar
changed the title
dimpar
force-pushed
the
minimal-number-of-supporting-signatures
branch
from
5dfef4e to
c7c1e48
Compare
We do not need more than 5 members in a group there.
We now require 75% of group members to sign the result. It gives us 25% safety margin for relay entry signing. This test had to be updated with the new margin values.
It does not make sense to submit result with less signatures than the on-chain contract expects. And the on-chain contract expects 25% safety margin.
Mistakenly ommitted in the previous commit.
Chain expects 75% of signatures on DKG result so that we have 25% safety margin for relay entry signing. It does not make sense to submit result not having enough signatures. The appropriate change has been applied to DKG result submitter. Here, we update tests to respect this change.
Member
|
@eth-r @ngrinkevich would love to have your 👀 on this one. |
dimpar
commented
Apr 17, 2020
Contributor
|
The solidity side looks good to me |
Member
|
And everything else looks good to me too. Let's merge. |
pdyraga
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1585
In this PR we are increasing the DKG nofail signature threshold to 75%. It gives us a 25% safety margin for relay entry signing.