Conversation
It is possible now to build a client with locally avaialble artifacts that were deployed on Geth. No need to provide contracts addresses that were required by the client for the local start.
- Setting KEEP_ETHEREUM_PASSWORD as env. var. Default password is password - Changing ./keep-core -> ./keep-client
nkuba
suggested changes
Aug 17, 2022
It is not necessary adding a LOCAL-* prefix, we can simplify namings.
Contributor
Author
nkuba
suggested changes
Aug 18, 2022
nkuba
reviewed
Aug 18, 2022
Member
nkuba
left a comment
nkuba
left a comment
There was a problem hiding this comment.
Non-blocking comment, it's just my feeling.
nkuba
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses changes made in #3129 to use the locally deployed artifacts. Now
install.shwill build the client with the local artifacts. Also,start.shcan be used now to start a client.To start a client we need to:
Manually configure
config.tomlin the/configsdir. Providing contract addresses is no longer required for "development" env. Next:scripts/install.shscripts/initialize.sh --stake-owner <address>scripts/start.shAvailable params for
start.shKEEP_ETHEREUM_PASSWORDenv var. If not provided, "password" is used--config-dirpath to the config file./configsis defaultRefs #3135