Merge together state and faststate packages#3365
Merged
lukasz-zimnoch merged 6 commits intomainfrom Oct 25, 2022
Merged
Conversation
The goal of the changes is to merge together `faststate` and `state` packages. Instead of two packages, we are going to have one `state` package with two implementations of the state machine: asynchronous and synchronous.
The goal of the changes is to merge together `faststate` and `state` packages. Instead of two packages, we are going to have one `state` package with two implementations of the state machine: asynchronous and synchronous.
The goal of the changes is to merge together `faststate` and `state` packages. Instead of two packages, we are going to have one `state` package with two implementations of the state machine: asynchronous and synchronous.
The goal of the changes is to merge together `faststate` and `state` packages. Instead of two packages, we are going to have one `state` package with two implementations of the state machine: asynchronous and synchronous.
The goal of the changes is to merge together `faststate` and `state` packages. Instead of two packages, we are going to have one `state` package with two implementations of the state machine: asynchronous and synchronous.
The goal of the changes is to merge together `faststate` and `state` packages. Instead of two packages, we are going to have one `state` package with two implementations of the state machine: asynchronous and synchronous. state.SyncMachine is meant to be used with interactive protocols when participants are expected to synchronize based on the number of blocks being mined at the time the protocol is executing. Even if the given participant received all the necessary information to continue the protocol, the state machine waits with proceeding to the next step for the fixed duration of blocks. This approach is the most optimal when the protocol may finish successfully even if some members expected to participate in the execution are inactive. state.AsyncMachine is meant to be used with interactive protocols when participants are expected to synchronize based on the messages being sent and some participants may be slower than others. Each protocol participant, to finish the execution, must wait for the slowest participant. This approach is the most optimal when the protocol may finish successfully only if all members expected to participate in the execution are actively participating.
Merged
lukasz-zimnoch
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3366
See this discussion: #3362 (comment)
The goal of the changes is to merge together
faststateandstatepackages. Instead of two packages, we are going to have onestatepackage with two implementations of the state machine: asynchronous and synchronous.state.SyncMachineis meant to be used with interactive protocols when participants are expected to synchronize based on the number of blocks being mined at the time the protocol is executing. Even if the given participant received all the necessary information to continue the protocol, the state machine waits with proceeding to the next step for the fixed duration of blocks. This approach is the most optimal when the protocol may finish successfully even if some members expected to participate in the execution are inactive.state.AsyncMachineis meant to be used with interactive protocols when participants are expected to synchronize based on the messages being sent and some participants may be slower than others. Each protocol participant, to finish the execution, must wait for the slowest participant. This approach is the most optimal when the protocol may finish successfully only if all members expected to participate in the execution are actively participating.