go-electrum client dependency upgrade#3567
Merged
lukasz-zimnoch merged 2 commits intomainfrom May 16, 2023
Merged
Conversation
This commit contains changes from keep-network/go-electrum#1
Here we update electrum integration tests to cover changes introduced in keep-network/go-electrum#1. The go-electrum client no longer fails error unmarshaling. Also electrum server implementations return specific error messages that we want to compare in tests.
lukasz-zimnoch
approved these changes
May 16, 2023
This was referenced May 17, 2023
pdyraga
added a commit
that referenced
this pull request
May 17, 2023
This is a follow-up for #3567. We pin go-electrum dependency to a commit hash from master after merging the keep-network/go-electrum#1 PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: keep-network/go-electrum#1
In this PR we update Electrum client dependency and integration tests to cover changes introduced in
keep-network/go-electrum#1.
The go-electrum client no longer fails error unmarshaling. Also electrum
server implementations return specific error messages that we want to
compare in tests.
To run the integration test execute:
go test -v -tags=integration ./pkg/bitcoin/electrum.go.modwas pinned to a commit from a PR branch, we need to update it after the changes in keep-network/go-electrum#1. are merged to master.