Updates to OZ manifest files and deployment metadata after TokenStaking upgrade #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdyraga
previously approved these changes
Sep 29, 2022
nkuba
previously approved these changes
Sep 29, 2022
…ayout A previous commit in the TokenStaking contract (6eaf4d5) introduced a potential change in the contract storage layout that is detected by the OZ Upgrades tool: Error: New storage layout is incompatible contracts/staking/TokenStaking.sol:130: Upgraded `slashingQueue` to an incompatible type - In struct TokenStaking.SlashingEvent[] - Bad upgrade to struct TokenStaking.SlashingEvent - In struct TokenStaking.SlashingEvent - Deleted `application` > Keep the variable even if unused The good news is that this struct is still unused since there are no real applications running yet, so there's no consequences. As a workaround, we decided to tweak the OZ Upgrades layout file to adapt to the new layout. Going forward we will implement automatic checks that verify the layout of any potential change to the staking contract.
cygnusv
force-pushed
the
oz_and_friends
branch
from
1086dbe to
d25839c
Compare
nkuba
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.