Skip to content

Fix disabled checkbox input#231

Merged
devmount merged 3 commits intomainfrom
bugs/320-fix-disabled-checkbox-input
Mar 4, 2026
Merged

Fix disabled checkbox input#231
devmount merged 3 commits intomainfrom
bugs/320-fix-disabled-checkbox-input

Conversation

@devmount
Copy link
Copy Markdown
Collaborator

Description of the Change

This change fixes:

  • The CheckboxInput component handling changes on the disabled prop
  • The checkbox being squeezed together on small viewports

An story was added with controls to change the checked state and the disabled state:

image

Related tickets

Closes #230

@devmount devmount self-assigned this Feb 27, 2026
@devmount devmount changed the title Bugs/320 fix disabled checkbox input Fix disabled checkbox input Feb 27, 2026
Copy link
Copy Markdown
Contributor

@davinotdavid davinotdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀

Might be worth to cut a patch version for this.

@davinotdavid
Copy link
Copy Markdown
Contributor

davinotdavid commented Mar 3, 2026

@devmount sorry, one more thing!

Apparently the disable checkbox style should be this:

image

Instead of the opacity that we are doing. Could you also fix that in this PR? 🙏

https://app.zeplin.io/project/66dd0f2b2fe8f1b63cda36f1/screen/699dfcb1356b9935aab9e618

@devmount devmount requested a review from davinotdavid March 4, 2026 14:33
@devmount
Copy link
Copy Markdown
Collaborator Author

devmount commented Mar 4, 2026

@davinotdavid Fixed the disabled colors. Thanks for finding this!

@devmount
Copy link
Copy Markdown
Collaborator Author

devmount commented Mar 4, 2026

Merging this in for now.

@devmount devmount merged commit d73d4c4 into main Mar 4, 2026
1 check passed
@devmount devmount deleted the bugs/320-fix-disabled-checkbox-input branch March 4, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CheckboxInput that is disabled=false is disabled

2 participants