Skip to content

uplift(beta): fix missing beta NoOpFeatureFlagOverrides #10239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coreycb merged 1 commit into from
Dec 9, 2025
Merged

uplift(beta): fix missing beta NoOpFeatureFlagOverrides #10239

coreycb merged 1 commit into from
Dec 9, 2025

Conversation

@wmontwe
Copy link
Member

@wmontwe wmontwe commented Dec 9, 2025 •
edited
Loading

Uplift #10233 to beta

Seen in: 16.0b1

@wmontwe
Merge pull request thunderbird#10233 from wmontwe/fix-10230-missing-b…
aa2d583 
…eta-feature-flag-overrides

fix: add missing beta NoOpFeatureFlagOverrides
@wmontwe wmontwe requested a review from a team as a code owner December 9, 2025 14:45
@wmontwe wmontwe requested review from dani-zilla and removed request for a team December 9, 2025 14:45
@thunderbird-botmobile
Copy link
Contributor

thunderbird-botmobile bot commented Dec 9, 2025 •
edited by wmontwe
Loading

Thank you for your uplift request! Please add a comment with the following approval request template filled out.

[Approval Request]
Original Issue/Pull request: #10230
Regression caused by (issue #): #10103
User impact if declined: App won't start
Testing completed (on daily, beta, etc.): daily, beta
Introduces or modifies localizable strings (yes/no): no
Skips a database migration (yes/no): no
Risk to taking this patch (and alternatives if risky): Low as it adds a missing code path

@wmontwe wmontwe changed the title Merge pull request #10233 from wmontwe/fix-10230-missing-beta-feature… uplift(beta): fix missing beta NoOpFeatureFlagOverrides Dec 9, 2025
dani-zilla
dani-zilla approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@dani-zilla dani-zilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coreycb coreycb merged commit cb5d2be into thunderbird:beta Dec 9, 2025
15 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 16 milestone Dec 9, 2025
@wmontwe wmontwe deleted the uplift-beta-fix-10230-missing-beta-feature-flag-overrides branch December 9, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coreycb coreycb coreycb approved these changes

@dani-zilla dani-zilla dani-zilla approved these changes

Assignees

@dani-zilla dani-zilla

Labels

None yet

Projects

None yet

Milestone

Thunderbird 16

Development

Successfully merging this pull request may close these issues.

3 participants

@wmontwe @coreycb @dani-zilla