Skip to content

fix(message-view): Respect animation setting when displaying message body#10796

Open
untitaker wants to merge 1 commit intothunderbird:mainfrom
untitaker:webview-animations-off
Open

fix(message-view): Respect animation setting when displaying message body#10796
untitaker wants to merge 1 commit intothunderbird:mainfrom
untitaker:webview-animations-off

Conversation

@untitaker
Copy link
Copy Markdown

Description:

Disable fade-in animation when opening messages if the user has disabled animations in Thunderbird's own app settings.

The fix was written with AI, but testing, code review and commit messages were done manually.

Fixes #1903

Testing:

  1. Go to Settings > General > Display > Use gaudy... and disable it
  2. Open any email message
  3. Verify the message content appears without fade-in

In most cases the message view still loads in steps and feels jumpy, but without any animation.

…body

**Description:**

Disable fade-in animation when opening messages if the user has disabled animations in Thunderbird's own app settings.

The fix was written with AI, but testing, code review and commit messages were done manually.

Fixes thunderbird#1903

**Testing:**

1. Go to Settings > General > Display > Use gaudy... and disable it
2. Open any email message
3. Verify the message content appears without fade-in

In most cases the message view still loads in steps and feels jumpy, but without any animation.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Missing report label. Set exactly one of: report: include, report: exclude OR report: highlight.

@untitaker
Copy link
Copy Markdown
Author

untitaker commented Apr 7, 2026

ViewSwitcher.java works different than this fix: It sets up animations explicitly in code only if the animation setting is enabled, while this view sets up animations in message.xml and here I added code to conditionally remove them again. Just went for the most minimal fix, but happy to do a broader refactor so animation settings are applied the same way across views.

@rafaeltonholo rafaeltonholo added the merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Missing report label. Set exactly one of: report: include, report: exclude OR report: highlight.

untitaker added a commit to untitaker/thunderbird-android that referenced this pull request Apr 7, 2026
Convert the "Use gaudy visual effects" boolean checkbox to a tri-state
option (On/Off/Use system default) that defaults to following Android's
system animation accessibility setting.

Similar to ThemeManager, introduce a new AnimationManager and funnel all access to this option through there. I'm on the
fence as to whether that isn't too much overkill, IMO it would make sense to merge them both into one "settings
manager".

Right now there is only one place where the setting is being read, in ViewSwitcher. However, there are many other places
where the setting is supposed to be respected but isn't (sidebar, messagetopview thunderbird#10796) so I figured it's better to
centralize the resolution outside of ViewSwitcher.
@wmontwe wmontwe removed the merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Missing report label. Set exactly one of: report: include, report: exclude OR report: highlight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fade-in animation when opening message plays even when animations are disabled

3 participants