fix: Correctly escape recent changelog entries on release branch #9175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreycb
approved these changes
May 16, 2025
Member
|
Fixed the badging information |
Member
|
The build is failing because of an old issue with Spotless, that is fixed on main and beta already. I've run the build locally and it succeeds. Either we merge this as is or we need to backport the Spotless fix first. |
Member
Author
|
Is the spotless failure uncovered through these changes in some way? I think the only think we need to avoid is that this spotless failure is going to make the release builds fail. If that isn't the case (e.g. it worked for the last release build which should have the same spotless errors), then we could merge. |
Member
|
It's a combination of Gradle cache and Spotless, it might happen for release too. |
Member
Author
|
If there is a chance it might succeed, I guess we can always backport the spotless fix if the release fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9122