Skip to content

Fix u32 overflow when parsing package references with ridiculously large/long version numbers #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025
+6 −6
Merged

Fix u32 overflow when parsing package references with ridiculously large/long version numbers #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/ts/version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ use serde_with::{DeserializeFromStr, SerializeDisplay};
SerializeDisplay, DeserializeFromStr, Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Hash,
)]
pub struct Version {
pub major: u32,
pub minor: u32,
pub patch: u32,
pub major: u64,
pub minor: u64,
pub patch: u64,
}

impl Version {
pub const fn new(major: u32, minor: u32, patch: u32) -> Version {
pub const fn new(major: u64, minor: u64, patch: u64) -> Version {
Version {
major,
minor,
Expand All @@ -34,12 +34,12 @@ impl FromStr for Version {
type Err = VersionParseError;

fn from_str(s: &str) -> Result<Self, Self::Err> {
let [major, minor, patch]: [u32; 3] = s
let [major, minor, patch]: [u64; 3] = s
.splitn(3, '.')
.map(|n| n.parse())
.collect::<Result<Vec<_>, _>>()?
.try_into()
.map_err(|v: Vec<u32>| VersionParseError::DotCount(v.len() - 1))?;
.map_err(|v: Vec<u64>| VersionParseError::DotCount(v.len() - 1))?;

Ok(Version {
major,
Expand Down
Loading