fix: CosmosException's statusCode not correct when 429 in batchExecute#85
Merged
thunderz99 merged 2 commits intoJun 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
When
batchExecutefails 10 times due to a 429 status code, aCosmosExceptionwith status code 0 will be thrown. This makes it difficult for programs callingbatchExecuteto catch this exception and correctly identify the status code.Expectation
A
CosmosExceptionwith status code 429 (the same as the root cause's status code) should be thrown. This way, the caller can catch the exception and obtain a reasonable status code for further processing.Way to Fix
Modify the status code of the thrown
CosmosExceptionand add a corresponding unit test.