Grab id for exception message from request object

[mecampbellsoup]

No need for the regex as the desired id attribute is available as an instance variable on the request object.

[mecampbellsoup]

@tiagopog this regex was failing in our test suite because we are using UUIDs as primary keys, which aren't strings of strictly digits.

[mecampbellsoup]

@tiagopog we should get automated builds set up for this gem, I think you can do it for free using Travis CI or Circle CI.

[tiagopog]

Sure, I actually started working on that. Up to the weekend I guess we're done.

[mecampbellsoup]

👍

[tiagopog]

Well, in this case we would need to test when there is more than one identifier being passed in the request. I'm not sure right now if we could easily know which one was not found using only the request object. Through the exception message it's quite easy to "access" this information. But I'm totally open for suggestions, especially now considering the case of uuid's.

[tiagopog]

Hey, just let me know when you finish testing the suggested code against a request with multiple identifiers e.g. /users/:user_id/posts/:id – it needs to be capable to render a not found error pointing to the correct identifier (:user_id or :id).

[tiagopog]

I have some work to get done now, so I may also test it later :-)

[mecampbellsoup]

Will do man, not going to be today, hopefully tomorrow or later this week :)

On April 13, 2016 at 11:38:02 AM, Tiago Guedes (notifications@github.com) wrote:

I have some work to get done now, so I may also test it later :-)

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub