Compatibility with jsonapi-resources@0.9.7 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasnoukhov
force-pushed
the
resources-0.9.5
branch
from
b7d26d8 to
bd2b0b1
Compare
Contributor
Author
|
Not sure why Travis does not run here, but here's a build: https://travis-ci.org/simplepractice/jsonapi-utils/builds/509436787 |
Contributor
Author
|
Tested against an internal suite (~600 examples), does not look like there are any issues |
krasnoukhov
changed the title
krasnoukhov
force-pushed
the
resources-0.9.5
branch
from
b7cdf99 to
8b3a49a
Compare
|
Hello! Could you tell me what's the status of this? @tiagopog |
Contributor
Author
|
I just updated this for latest version (0.9.7) |
krasnoukhov
changed the title
Owner
|
Hi, @krasnoukhov. Thanks for contributing and sorry for the delay on reviewing it. |
tiagopog
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are passing.
So far it seems like the only breaking change was this: cerebris/jsonapi-resources@970bc79
Closes #93