feat(docker): 支持 CI 构建 docker 镜像#247
Closed
jlovec wants to merge 2 commits into
Closed
Conversation
| @@ -224,1373 +224,1375 @@ | |||
| }, | |||
| }, | |||
| "packages": { | |||
| "@adobe/css-tools": ["@adobe/css-tools@4.4.4", "", {}, "sha512-Elp+iwUx5rN5+Y8xLt5/GRoG20WGoDCQ/1Fb+1LiGtvwbDavuSk0jhD/eZdckHAuzcDzccnkv+rEjyWfRx18gg=="], | |||
| "@adobe/css-tools": ["@adobe/css-tools@4.4.4", "http://mirrors.cloud.tencent.com/npm/@adobe/css-tools/-/css-tools-4.4.4.tgz", {}, "sha512-Elp+iwUx5rN5+Y8xLt5/GRoG20WGoDCQ/1Fb+1LiGtvwbDavuSk0jhD/eZdckHAuzcDzccnkv+rEjyWfRx18gg=="], | |||
|
|
|||
There was a problem hiding this comment.
[MAJOR] 依赖 tarball URL 使用 HTTP 镜像
Why this is a problem: bun.lock 中大量依赖指向 http:// 镜像,构建链路走明文传输,存在 MITM/降级与可用性风险,且不符合依赖下载的安全传输预期。
Suggested fix:
- "@adobe/css-tools": ["@adobe/css-tools@4.4.4", "http://mirrors.cloud.tencent.com/npm/@adobe/css-tools/-/css-tools-4.4.4.tgz", {}, "sha512-Elp+iwUx5rN5+Y8xLt5/GRoG20WGoDCQ/1Fb+1LiGtvwbDavuSk0jhD/eZdckHAuzcDzccnkv+rEjyWfRx18gg=="],
+ "@adobe/css-tools": ["@adobe/css-tools@4.4.4", "https://mirrors.cloud.tencent.com/npm/@adobe/css-tools/-/css-tools-4.4.4.tgz", {}, "sha512-Elp+iwUx5rN5+Y8xLt5/GRoG20WGoDCQ/1Fb+1LiGtvwbDavuSk0jhD/eZdckHAuzcDzccnkv+rEjyWfRx18gg=="],| volumes: | ||
| - cli-data:/data/hapi | ||
| - ${CLAUDE_CONFIG_DIR:-~/.claude}:/root/.claude | ||
| depends_on: |
There was a problem hiding this comment.
[MINOR] ~ 在 Compose 中不展开,默认挂载路径失效
Why this is a problem: ~/.claude 不会被 Docker Compose 展开为用户 Home,默认会变成字面路径,导致 Claude 配置目录未正确挂载。
Suggested fix:
- - ${CLAUDE_CONFIG_DIR:-~/.claude}:/root/.claude
+ - ${CLAUDE_CONFIG_DIR:?set CLAUDE_CONFIG_DIR in .env}:/root/.claudeIntroduce hub/cli Docker assets and CI image workflow, then address PR tiann#247 findings by switching bun.lock mirror tarball URLs to HTTPS and requiring explicit CLAUDE_CONFIG_DIR in compose (no '~' expansion assumption). This keeps docker builds reproducible while avoiding cleartext lockfile sources and ambiguous host mount behavior.
999eff2 to
3a6c74f
Compare
Contributor
Author
|
已按审查意见修复并整理为 1 个提交:\n- bun.lock 中 mirror tarball URL 已从 http 切换为 https\n- docker-compose 不再依赖 '~' 展开,改为要求显式 CLAUDE_CONFIG_DIR\n- README 已更新为必须提供绝对路径\n\n请重新触发检查,谢谢。 |
jlovec
added a commit
to jlovec/zhushen
that referenced
this pull request
Mar 6, 2026
Introduce hub/cli Docker assets and CI image workflow, then address PR tiann#247 findings by switching bun.lock mirror tarball URLs to HTTPS and requiring explicit CLAUDE_CONFIG_DIR in compose (no '~' expansion assumption). This keeps docker builds reproducible while avoiding cleartext lockfile sources and ambiguous host mount behavior.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
bun.lock,修复bun install --frozen-lockfile在 Docker 构建中的失败问题。Dockerfile.cli中改为使用bun add -g @anthropic-ai/claude-code安装 Claude Code,避免 Bun 基础镜像中缺少npm导致构建失败。背景
此前 PR 的 Docker workflow 在构建阶段失败,主要原因有两点:
--frozen-lockfile直接失败。npm install -g,但镜像环境无可用 npm 命令。验证
Docker Imagesworkflow 已通过(hub/cli 均成功)。风险与兼容性