fix(runner): restart when hub identity changes#303
Merged
tiann merged 2 commits intotiann:mainfrom Mar 18, 2026
Merged
Conversation
There was a problem hiding this comment.
Findings
- [Major] Identity mismatch not detected when current identity missing — optional checks mean clearing settings/env can keep stale runner bound to old hub/namespace. evidence
cli/src/runner/runnerIdentity.ts:29cli/src/runner/runnerIdentity.ts:33
Suggested fix:if (!current.machineId || state.startedWithMachineId !== current.machineId) { return false } if (!current.cliApiTokenHash || state.startedWithCliApiTokenHash !== current.cliApiTokenHash) { return false }
Summary
- Review mode: initial
- 1 major issue. Identity check allows stale runner when current identity missing.
Testing
- Not run (automation)
- Suggested: add test for missing current machineId/token to lock behavior.
cli/src/runner/runnerIdentity.ts
Outdated
| return false | ||
| } | ||
|
|
||
| if (current.machineId && state.startedWithMachineId !== current.machineId) { |
There was a problem hiding this comment.
[MAJOR] Identity mismatch not detected when current identity missing — optional checks mean clearing settings/env can keep stale runner bound to old hub/namespace.
Suggested fix:
if (!current.machineId || state.startedWithMachineId !== current.machineId) {
return false
}
if (!current.cliApiTokenHash || state.startedWithCliApiTokenHash !== current.cliApiTokenHash) {
return false
}
Hwwwww-dev
pushed a commit
to Hwwwww-dev/hapi
that referenced
this pull request
Mar 20, 2026
* fix(runner): restart when hub identity changes * fix(runner): fail closed on missing identity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing