Skip to content

fix(codex): keep local session timeout non-fatal#304

Merged
tiann merged 1 commit intotiann:mainfrom
ROOOO:pr/codex-local-timeout-non-fatal
Mar 17, 2026
Merged

fix(codex): keep local session timeout non-fatal#304
tiann merged 1 commit intotiann:mainfrom
ROOOO:pr/codex-local-timeout-non-fatal

Conversation

@ROOOO
Copy link
Contributor

@ROOOO ROOOO commented Mar 17, 2026

Summary

  • stop treating Codex local session matching timeouts as a fatal launcher failure
  • keep the local Codex process running even when transcript/session adoption cannot be established
  • surface a warning that remote transcript sync may be unavailable for that launch
  • add coverage for the non-fatal warning path alongside existing local launcher mode tests

Testing

  • bun x vitest run src/codex/codexLocalLauncher.test.ts
  • bun run typecheck

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • None.

Summary

  • Review mode: initial. No issues found in added/modified lines. Residual risk: runtime behavior when the real Codex session scanner times out remains only unit-covered here.

Testing

  • Not run (automation)

@tiann tiann merged commit a30bb39 into tiann:main Mar 17, 2026
2 checks passed
@ROOOO ROOOO deleted the pr/codex-local-timeout-non-fatal branch March 19, 2026 13:17
Hwwwww-dev pushed a commit to Hwwwww-dev/hapi that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants