fix(hub): pass resumeSessionId when resuming session#337
Merged
tiann merged 1 commit intotiann:mainfrom Mar 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a resume argument wiring bug in
SyncEngine.resumeSession()that prevents hub-triggered session resume from passing the actual resume token to the CLI spawn RPC.Root cause
rpcGateway.spawnSession()takes params in this order:In
hub/src/sync/syncEngine.ts,resumeTokenwas passed as the 8th argument (worktreeName) instead of the 9th argument (resumeSessionId).So for resume flow:
metadata.claudeSessionId(or other flavor token)resumeSessionId--resume <id>Fix
In
hub/src/sync/syncEngine.ts:undefinedforworktreeNameresumeTokenas the 9th arg (resumeSessionId)Tests
Added regression test in
hub/src/sync/sessionModel.test.ts:passes resume session ID to rpc gateway when resuming claude sessionengine.resumeSession()forwardsmetadata.claudeSessionIdinto rpcspawnSession(..., resumeSessionId)Also keeps existing model-forwarding resume test intact.
Validation
cd hub && bun run test src/sync/sessionModel.test.tsImpact