fix(cli): honor HAPI_HOSTNAME in session metadata#449
Merged
hqhq1025 merged 1 commit intotiann:mainfrom Apr 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Findings
- None.
Summary
Review mode: initial. No diff-introduced correctness, security, regression, or maintainability issues found in the modified lines. Residual risk: this change only adds a focused env-override test, and fallback behavior to os.hostname() was not re-verified in automation here.
Testing
- Not run (automation):
bunis not installed in this runner, so I could not executecli/src/agent/sessionFactory.test.ts.
HAPI Bot
Hwwwww-dev
pushed a commit
to Hwwwww-dev/hapi
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This small fix makes session metadata use
HAPI_HOSTNAMEthe same way machine metadata already does.Problem
Today
HAPI_HOSTNAMEaffects machine metadata, but session metadata still recordsos.hostname()directly.That can be confusing in self-hosted setups where multiple clients share the same system hostname but are intentionally distinguished with
HAPI_HOSTNAME.Change
process.env.HAPI_HOSTNAME || os.hostname()inbuildSessionMetadata()Why
This keeps machine host and session host consistent, and improves host-based display / fallback behavior without changing default behavior for users who do not set
HAPI_HOSTNAME.