fix(cli): prevent CLAUDE_CODE_ENTRYPOINT leak into local spawn#452
Merged
hqhq1025 merged 1 commit intotiann:mainfrom Apr 14, 2026
Merged
fix(cli): prevent CLAUDE_CODE_ENTRYPOINT leak into local spawn#452hqhq1025 merged 1 commit intotiann:mainfrom
hqhq1025 merged 1 commit intotiann:mainfrom
Conversation
extractSDKMetadataAsync() calls query() which sets CLAUDE_CODE_ENTRYPOINT='sdk-ts' on the current process env. When claudeLocal() later spawns the claude CLI, the child inherits this env var, causing Claude Code to treat the session as SDK-launched. This makes the session invisible to `claude --resume`. Strip CLAUDE_CODE_ENTRYPOINT from the child env so the local spawn uses its own default entrypoint. Closes tiann#450
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings
- None.
Summary
Review mode: initial
No diff-scoped correctness, security, or regression issues found in the added/modified lines.
Residual risk/testing gap: the fix in cli/src/claude/claudeLocal.ts:85 is only covered by the manual PR test plan; I did not find an automated regression test that asserts CLAUDE_CODE_ENTRYPOINT is stripped before the local Claude spawn.
Testing
Not run (automation)
HAPI Bot
Hwwwww-dev
pushed a commit
to Hwwwww-dev/hapi
that referenced
this pull request
Apr 17, 2026
…#452) extractSDKMetadataAsync() calls query() which sets CLAUDE_CODE_ENTRYPOINT='sdk-ts' on the current process env. When claudeLocal() later spawns the claude CLI, the child inherits this env var, causing Claude Code to treat the session as SDK-launched. This makes the session invisible to `claude --resume`. Strip CLAUDE_CODE_ENTRYPOINT from the child env so the local spawn uses its own default entrypoint. Closes tiann#450
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hapiare invisible toclaude --resumebecause the child process inheritsCLAUDE_CODE_ENTRYPOINT=sdk-tsfrom the parentextractSDKMetadataAsync()→query()sets this env var on the current process for SDK metadata extraction;claudeLocal()then spreadsprocess.envinto the child, leaking itCLAUDE_CODE_ENTRYPOINTbefore building the child env so the local spawn uses its own default entrypointTest plan
hapilocally (terminal mode)claude --resume— the session should now appear in the listCloses #450