Skip to content

Stop active Codex child agents on abort#615

Merged
tiann merged 4 commits into
tiann:mainfrom
SmallSpider0:fix/codex-stop-child-agents
May 12, 2026
Merged

Stop active Codex child agents on abort#615
tiann merged 4 commits into
tiann:mainfrom
SmallSpider0:fix/codex-stop-child-agents

Conversation

@SmallSpider0
Copy link
Copy Markdown
Contributor

Summary

  • Track active Codex child-agent turns by thread/turn id and interrupt them together with the parent turn when Stop/abort is invoked.
  • Reuse the same interruption path for Codex slash-command interruptions such as /clear and /compact.
  • Keep the composer Stop control enabled while Codex child-agent cards are still running, even after the parent turn is no longer marked as thinking.
  • Refresh bun.lock with the missing optional win32 HAPI package entry required by the current Bun lockfile validation during deploy builds.

Testing

  • cd cli && bun run test src/codex/codexRemoteLauncher.test.ts
  • cd web && bun run build
  • bun typecheck
  • Manual deployed verification: started a long-running Codex child agent from the web session and confirmed the Stop button remained clickable and stopped the child agent.

Review

  • Sub-agent review: PASS, no blockers.
  • Noted non-blocking risks: child interruption depends on child task_started events carrying thread_id and turn_id; web Stop-button behavior is manually verified but not covered by a dedicated web unit test.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • No issues found with confidence >= 80% in the added/modified lines.

Summary

  • Review mode: initial
  • Reviewed the full latest diff for Codex child-turn interruption, slash-command abort reuse, web runtime running-state propagation, and the lockfile update. Residual risk: the web Stop-button behavior for child-agent-only runs is not covered by a dedicated web unit/integration test; not found in repo/docs.

Testing

  • Not run (automation: bun is not installed in this runner).

HAPI Bot

@tiann tiann merged commit 088a712 into tiann:main May 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants