Fix hub SQLite cleanup on Windows#644
Merged
Merged
Conversation
There was a problem hiding this comment.
Findings
No issues found.
Summary
Review mode: initial
No correctness, security, data loss, performance, or maintainability findings met the reporting threshold in the latest diff. Residual risk: I could not execute the Bun test suite in this runner because bun is not installed.
Testing
Not run: bun is not installed in this runner.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store.close()method for Bun SQLite-backed hub storesWhy
Windows refuses to remove a temporary directory while SQLite still has WAL/SHM handles open. The affected hub tests created file-backed stores and then deleted the temp directory without explicitly closing the database.
Validation
bun run test -- src/store/migration-v8.test.ts src/store/migration-v9.test.ts src/sync/messageService.test.tsinhubbun run typecheck:hub