fix(web): respect manual session path collapse#656
Merged
Conversation
There was a problem hiding this comment.
Findings
- No high-confidence issues found in the added/modified lines.
Summary
- Review mode: initial
- Reviewed the latest diff for
web/src/components/SessionList.tsxandweb/src/components/SessionList.directory-action.test.tsx. Residual risk: browser-only collapse behavior was not exercised locally because the test runner is unavailable in this environment.
Testing
- Not run (automation;
bunnot found in this runner).
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix session list collapse behavior so a manually collapsed selected/running session path stays collapsed across live session-list refreshes.
Previously, when a selected active session kept receiving tool-call/message updates, the session list auto-expand effect would re-run on each refresh and immediately reopen the path the user had just collapsed. This made it difficult to collapse the current path and switch elsewhere to create or select another session.
Changes
(selectedSessionId, group.key)ref.Notes
This intentionally keeps “reveal selected session” behavior when selection changes. If the user selects a different session in the same group, the group can auto-expand again by design.
Validation
git diff --check origin/main..HEADbun typecheckbun --cwd web test src/components/SessionList.directory-action.test.tsx src/components/SessionList.test.tsenv -u HAPI_CLI_EXECUTABLE bun run testFull suite passed.