Update hapi runner command to use start-sync#685
Merged
Conversation
There was a problem hiding this comment.
Findings
- [Minor] macOS launchd instructions still use the ignored foreground flag — this PR updates pm2/nohup/systemd to run the foreground runner process directly, but the same deployment section still tells launchd users to run
hapi runner start --foreground;startdetaches and the CLI implementation only treatsstart-syncas the runner process, so launchd can supervise the short-lived parent instead of the runner. Evidence:docs/guide/installation.md:540; related stale context:docs/guide/installation.md:473.
Suggested fix:<array> <string>/usr/local/bin/hapi</string> <string>runner</string> <string>start-sync</string> </array>
Summary
- Review mode: initial
- One docs consistency issue found in the same background deployment section. The changed examples move to
start-sync, but the launchd example remains stale.
Testing
- Not run (automation)
HAPI Bot
There was a problem hiding this comment.
Findings
- No issues found in the modified lines.
Summary
- Review mode: follow-up after new commits
- The follow-up change updates the remaining launchd runner example to
hapi runner start-sync, matching the CLI behavior for supervised foreground runner processes. Residual risk: docs-only change; command examples were reviewed against current CLI source, but not executed under pm2/nohup/launchd/systemd.
Testing
- Not run (automation)
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--foregroundis ignored by hapi cliUse start-sync instead.