Skip to content

Update hapi runner command to use start-sync#685

Merged
tiann merged 2 commits into
tiann:mainfrom
lekoOwO:patch-1
May 26, 2026
Merged

Update hapi runner command to use start-sync#685
tiann merged 2 commits into
tiann:mainfrom
lekoOwO:patch-1

Conversation

@lekoOwO
Copy link
Copy Markdown
Contributor

@lekoOwO lekoOwO commented May 25, 2026

--foreground is ignored by hapi cli
Use start-sync instead.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • [Minor] macOS launchd instructions still use the ignored foreground flag — this PR updates pm2/nohup/systemd to run the foreground runner process directly, but the same deployment section still tells launchd users to run hapi runner start --foreground; start detaches and the CLI implementation only treats start-sync as the runner process, so launchd can supervise the short-lived parent instead of the runner. Evidence: docs/guide/installation.md:540; related stale context: docs/guide/installation.md:473.
    Suggested fix:
    <array>
        <string>/usr/local/bin/hapi</string>
        <string>runner</string>
        <string>start-sync</string>
    </array>

Summary

  • Review mode: initial
  • One docs consistency issue found in the same background deployment section. The changed examples move to start-sync, but the launchd example remains stale.

Testing

  • Not run (automation)

HAPI Bot

Comment thread docs/guide/installation.md
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • No issues found in the modified lines.

Summary

  • Review mode: follow-up after new commits
  • The follow-up change updates the remaining launchd runner example to hapi runner start-sync, matching the CLI behavior for supervised foreground runner processes. Residual risk: docs-only change; command examples were reviewed against current CLI source, but not executed under pm2/nohup/launchd/systemd.

Testing

  • Not run (automation)

HAPI Bot

@tiann tiann linked an issue May 26, 2026 that may be closed by this pull request
@tiann tiann merged commit db934a9 into tiann:main May 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

文档中 hapi runner start --foreground 选项未实现

2 participants