Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 9, 2025

Bumps golang.org/x/text from 0.29.0 to 0.30.0.

Commits
  • c6abd03 go.mod: update golang.org/x dependencies
  • 42f038d x/text: fix nil dereference in gotext extract
  • a42f0e2 all: use built-in max/min to simplify the code
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [golang.org/x/text](https://github.com/golang/text) from 0.29.0 to 0.30.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.29.0...v0.30.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-version: 0.30.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.42%. Comparing base (b1f4754) to head (b8fc9dd).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files          22       22           
  Lines        3690     3690           
=======================================
  Hits         2894     2894           
  Misses        658      658           
  Partials      138      138           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tobiasehlert tobiasehlert requested a review from Copilot October 17, 2025 17:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Dependabot PR to bump golang.org/x/text to v0.30.0.
Key changes:

  • Upgrades golang.org/x/text from v0.29.0 to v0.30.0.
  • Adds a new direct dependency on golang.org/x/net (v0.44.0), previously listed indirectly.
  • Updates several other golang.org/x indirect dependency versions (crypto, mod, sys, tools).

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

github.com/tibiadata/tibiadata-api-go/src/static v0.0.0-20250818132205-2b0f4da1df36
github.com/tibiadata/tibiadata-api-go/src/validation v0.0.0-20250811185450-4b0728b940bf
golang.org/x/text v0.29.0
golang.org/x/net v0.44.0
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The PR title/described scope is only 'bump golang.org/x/text', but this diff also introduces a new direct dependency on golang.org/x/net. Recommend updating the PR title/description to reflect the additional change or reverting this addition if unintended.

Suggested change
golang.org/x/net v0.44.0

Copilot uses AI. Check for mistakes.
golang.org/x/sys v0.35.0 // indirect
golang.org/x/tools v0.36.0 // indirect
golang.org/x/sys v0.36.0 // indirect
golang.org/x/tools v0.37.0 // indirect
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Multiple indirect golang.org/x module version bumps are included while the PR scope states only a text module update. Consider either adjusting the PR title to indicate a batch dependency update or splitting these changes so each PR has a single, clear purpose.

Suggested change
golang.org/x/tools v0.37.0 // indirect
golang.org/x/tools v0.35.0 // indirect

Copilot uses AI. Check for mistakes.
@tobiasehlert tobiasehlert merged commit a2efec5 into main Oct 17, 2025
7 checks passed
@tobiasehlert tobiasehlert deleted the dependabot/go_modules/golang.org/x/text-0.30.0 branch October 17, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Development

Successfully merging this pull request may close these issues.

2 participants