Skip to content

feat(web): add select page action#72

Merged
tickernelz merged 1 commit intotickernelz:mainfrom
tony027wh:feat/select-current-page
Mar 31, 2026
Merged

feat(web): add select page action#72
tickernelz merged 1 commit intotickernelz:mainfrom
tony027wh:feat/select-current-page

Conversation

@tony027wh
Copy link
Copy Markdown

Summary

  • add a bulk-action button to select all items on the current page
  • wire selection logic to update selected state and counts
  • add i18n strings for the new button in English and Chinese

Testing

  • bun run build

Copy link
Copy Markdown
Owner

@tickernelz tickernelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and simple implementation. Thanks!

One UX issue: the "Select Page" button is placed inside #bulk-actions which is hidden by default and only shows after at least one item is selected. This means users can't discover the "Select Page" button until they manually check one item first — which defeats the purpose of a "select all" action.

Suggestion: Move the "Select Page" button outside of #bulk-actions, or make it always visible alongside the existing toolbar buttons. The "Deselect All" and "Delete Selected" can stay inside bulk-actions since those make sense post-selection.

Once fixed, this is ready to merge.

Copy link
Copy Markdown
Owner

@tickernelz tickernelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The UX button placement is minor — can be fixed in a follow-up.

@tickernelz tickernelz merged commit 6f3071d into tickernelz:main Mar 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants