-
Notifications
You must be signed in to change notification settings - Fork 3
add private link connection command #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 773 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 203 | 1 | 569 | 0 |
Click to see the invalid file list
- internal/cli/serverless/privatelink/ui.go
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for managing private link connections in TiDB Cloud Serverless clusters. It introduces a new set of CLI commands and integrates with the TiDB Cloud API to create, list, describe, and delete private link connections for both AWS and Alicloud endpoint services.
- Generated OpenAPI client code for the private link connection API
- Added CLI commands (create, delete, describe, list, zones) under
serverless private-link-connection - Integrated private link connection API client with the existing cloud service infrastructure
- Added interactive and non-interactive modes for all commands with proper validation
Reviewed changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/tidbcloud/v1beta1/serverless/privatelink/* |
Auto-generated OpenAPI client code for private link connection API |
internal/service/cloud/api_client.go |
Added API client delegate methods for private link connection operations |
internal/service/cloud/logic.go |
Added business logic for selecting and retrieving private link connections |
internal/cli/serverless/privatelink/*.go |
CLI command implementations for create, delete, describe, list, and zones operations |
internal/flag/flag.go |
Added new flag constants for private link connection parameters |
internal/cli/serverless/cluster.go |
Integrated private link connection command into serverless CLI |
internal/mock/api_client.go |
Updated mock client with private link connection methods |
docs/generate_doc/*.md |
Auto-generated documentation for new CLI commands |
Makefile |
Added generation target for private link client |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.