Add support to set object properties via XML#765
Conversation
|
Great work! I guess we need a test app added @feons ? |
|
Yup! Please include a test app for this PR. Thank you! |
|
I haven't done one of the test apps for Alloy before but I will take a look at what it takes to create one. Thanks! |
|
@brentonhouse, to get started you can use this command in your Alloy repo |
|
@FokkeZB the |
|
@feons @brentonhouse This should go into 2.0.0, can we schedule this? |
|
@feons Please review. This can even go pre 2.0.0 since I do not see a breaking change here. |
|
@ewanharris @brentonhouse Ping! Can this please be reviewed? Highly demanded feature. |
ewanharris
left a comment
There was a problem hiding this comment.
Similar to #765, I think it'd be best to do this in the initial pass in getParserArgs. Before we set the the attribute on createArgs here, we could maybe check if it's a dotted property and then split the property and key name to be set on createArgs?
ewanharris
left a comment
There was a problem hiding this comment.
The changes look good to me!
Merging
PR for https://jira.appcelerator.org/browse/ALOY-1363