Skip to content

refactor: fix invalid version comparisons#960

Merged
ewanharris merged 3 commits intotidev:masterfrom
ewanharris:ALOY-1720
Jul 13, 2020
Merged

refactor: fix invalid version comparisons#960
ewanharris merged 3 commits intotidev:masterfrom
ewanharris:ALOY-1720

Conversation

@ewanharris
Copy link
Copy Markdown
Member

JIRA: ALOY-1720

  • Matrix calls - As we were using the version to basically do feature detection I went with checking if the functions existed rather than using an SDK version check
  • M2_320 check - As we've dropped support for Mobilweb and 3.2.0 is years old, I went with removing the version check and just having it be a OS_MOBILEWEB check

Rather than drop in semver at a (albeit small) size cost, use a feature check for the createMatrix calls, and remove the version check from the mobileweb check.
@build
Copy link
Copy Markdown

build commented Jun 30, 2020

Messages
📖

✅ All tests are passing
Nice one! All 3490 tests are passing.

Generated by 🚫 dangerJS against e82f2c7

Copy link
Copy Markdown
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ewanharris ewanharris merged commit 87c2f9e into tidev:master Jul 13, 2020
@ewanharris ewanharris deleted the ALOY-1720 branch July 13, 2020 13:51
@ewanharris
Copy link
Copy Markdown
Member Author

Merging as needs to be released for QE testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants