Improve checking of parameter inputs to parameters() and grid_*() functions#437
Merged
Improve checking of parameter inputs to parameters() and grid_*() functions#437
parameters() and grid_*() functions#437Conversation
check early for both parameter class and no unknowns so that we get a better error call than via `parameters()` or `validate_params()` from `make_*()` check that the dots are empty for #434
`validate_params()` can be removed when the user-facing `grid_max_entropy()` and `grid_latin_hypercube()` are removed and `make_max_entropy_grid()` and `make_latin_hypercube_grid()` don't need `validate_params()` anymore
mainly to test for duplicate names again as intended
Member
Author
|
Pulling out this commit description for more visibility: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #422
This fixes most of what's laid out in the reprex from the issue (comments still refer to the old behavior). It doesn't add a better error for
grid_*.default()since that's a separate issue (#429).Created on 2026-04-08 with reprex v2.1.1
The formatting of "Argument 2" as code isn't exactly perfect but comes from
stop_input_type()which I (currently) don't think is worth taking apart to customize.I ran revdep checks and it flags tdarec but that's because it's pulling in the unexported check function...
https://github.com/tdaverse/tdarec/blob/1f60a200f2d67a607ea7c774d62d20ab2ebefef8/R/vpd-summarizers.R#L34