Threading the call through #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`forge()` errors in `validate_column_names()` but call should show the user-facing function, i.e., `forge()` Going _up_ the call stack - `validate_column_names()` throws the error - `shrink()`: exported but we do want forge to bubble up outside of hardhat - `forge_*_default_clean()` - `run_forge()` methods for blueprints
Includes the exported but dev-facing `run_mold()` methods, similar to `run_forge()`
companion to pass call to `recompose()` from `mold()`, just up the other branch of the call tree
hfrick
added a commit
to tidymodels/extratests
that referenced
this pull request
Dec 11, 2024
This was referenced Jan 23, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #274
This PR passes the call down to the helper functions that show up in the snapshots. It's not attempting to follow every path up from every abort call but I figured the PR is big enough already. The snapshots cover the errors we care most about, so that's a good start.
This PR also adds a
callargument tovalidate_column_names()andrecompose(), as requested in #273. (The one forweighted_table()is still to come.)