Skip to content

correct theory_type on stat = "diff in props" w factor #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2021
Merged

correct theory_type on stat = "diff in props" w factor #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ not supply sufficient information to calculate an observed statistic
`direction` argument in `get_p_value()` and `shade_p_value()` (#355)
- Fixed bug in `calculate()` for `stat = "t"` to allow for handling
columns named `x`
- Fixed bug in `shade_p_value` where the package would erroneously warn when
`stat = "diff in props"` and one of the variables was a factor with more than
two levels.
- Various bug fixes and improvements to internal consistency

## Other
Expand Down
4 changes: 2 additions & 2 deletions R/set_params.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ set_params <- function(x) {
# Two sample proportions (z distribution)
# Parameter(s) not needed since standard normal
if (
(length(levels(response_variable(x))) == 2) &
(length(levels(explanatory_variable(x))) == 2)
(length(unique(response_variable(x))) == 2) &
(length(unique(explanatory_variable(x))) == 2)
) {
attr(x, "theory_type") <- "Two sample props z"
} else {
Expand Down