correct theory_type on stat = "diff in props" w factor

[simonpcouch]

Closes #374. :-)

library(tidyverse)
library(infer)
data(gss)

# partyid coded as factor

gss_rd <- gss %>%  filter(partyid %in% c("rep", "dem"))

class(gss_rd$partyid)
#> [1] "factor"

gss_null<-gss_rd %>% specify(college ~ partyid, success = "degree") %>%
  hypothesize(null = "independence") %>% 
  generate(reps = 1000, type = "permute") %>% 
  calculate(stat = "diff in props", order = c("rep", "dem")) 

gss_stat <- gss_rd %>% specify(college ~ partyid, success = "degree") %>%
  calculate(stat = "diff in props", order = c("rep", "dem")) 

gss_null %>% visualise()+shade_p_value(obs_stat = gss_stat, direction = "both")

# ...or as character
gss_rd <- gss %>%  filter(partyid %in% c("rep", "dem")) %>% mutate(partyid = as.character(partyid) )

class(gss_rd$partyid)
#> [1] "character"

gss_null<-gss_rd %>% specify(college ~ partyid, success = "degree") %>%
  hypothesize(null = "independence") %>% 
  generate(reps = 1000, type = "permute") %>% 
  calculate(stat = "diff in props", order = c("rep", "dem")) 

gss_stat <- gss_rd %>% specify(college ~ partyid, success = "degree") %>%
  calculate(stat = "diff in props", order = c("rep", "dem")) 

gss_null %>% visualise()+shade_p_value(obs_stat = gss_stat, direction = "both")

^{Created on 2021-04-03 by the reprex package (v1.0.0.9001)}

[simonpcouch]

Could be worth a message here, as I can imagine some cases (under resampling with some levels with small n?) where this could be worth noting. x here, though, draws from the data frame inputted to specify (i.e. this happens before resampling with generate), so I don't think we need to warn or add an argument.

[echasnovski]

Thank you, this looks good!

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.