move .filter_eval_time to standalone #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfrick
approved these changes
Dec 11, 2023
Member
hfrick
left a comment
hfrick
left a comment
There was a problem hiding this comment.
All .filter_eval_time() related changes are 👍
The change in .check_cens_type() looks like a linting change to me but it causes a snaphot test in extratest to break so I would suggest undoing that one.
topepo
added a commit
to tidymodels/tune
that referenced
this pull request
Dec 11, 2023
topepo
added a commit
to tidymodels/tune
that referenced
this pull request
Dec 11, 2023
…#780) * move function to new file * change function order for docs * documentation start * updates to the show/select functions * updates to select/show functions * updates for selecting eval times * remove commented out code * bug fix * metric test cases * add a survival model object * note for next PR * select/show test cases * small set of direct tests * update snapshot * Apply suggestions from code review Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com> * Apply suggestions from code review * updates from previous review * small cli update * doc update * refresh snapshots * modularize a check * Remake with newest CRAN version of scales for #775 * argument checks for tune functions * Apply suggestions from code review Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com> * add dot when function is invoked * add a warning for eval times with non-survival models * go back to enquos * rework warning text * rework warning text pt 2 * unit tests for regression and classification * caller envs * unit tests * rework call envs * survival unit tests * Apply suggestions from code review Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com> * update tests for more recent version of yardstick * use standalone file from tidymodels/parsnip#1034 --------- Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in tidymodels/tune#780
The error and warning both use cli now so we might see some extratest breakages. I will investigate that.