give .filter_eval_time() more informative warning #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
approved these changes
Jan 11, 2024
|
|
||
| cli::cli_warn( | ||
| c( | ||
| "There {?was/were} {diffs} inappropriate evaluation time \\ |
hfrick
approved these changes
Jan 11, 2024
Member
hfrick
left a comment
hfrick
left a comment
There was a problem hiding this comment.
Looove it! 😍 Does this break any snapshots in extratests?
| Condition | ||
| Warning: | ||
| There was 1 inappropriate evaluation time point that was removed. | ||
| There was 1 inappropriate evaluation time point that was removed. They were: |
Member
There was a problem hiding this comment.
Nit: They were -> It was. I'll add a suggestion!
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
Member
Author
|
i didn't test extratests because I still have a hard time making it run 😓 |
Member
|
I searched the extratests snapshots and didn't see any matches to the old message. Either way, I seem to be updating the snapshots almost every 3h 😄 |
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #967
I went all in! it is super fancy now