changes for issues #120 and #115 #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
* installing *source* package ‘devtools’ ...
** package ‘devtools’ successfully unpacked and MD5 sums checked
** R
** inst
** byte-compile and prepare package for lazy loading
Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) :
there is no package called ‘magrittr’
ERROR: lazy loading failed for package ‘devtools’
* removing ‘/home/travis/R/Library/devtools’
* restoring previous ‘/home/travis/R/Library/devtools’
The downloaded source packages are in
‘/tmp/RtmpUhu1j4/downloaded_packages’
Warning message:
In install.packages(c("devtools")) :
installation of package ‘devtools’ had non-zero exit status
```
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 72.72% 73.04% +0.31%
==========================================
Files 36 36
Lines 2651 2656 +5
==========================================
+ Hits 1928 1940 +12
+ Misses 723 716 -7
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 72.72% 73.04% +0.31%
==========================================
Files 36 36
Lines 2651 2656 +5
==========================================
+ Hits 1928 1940 +12
+ Misses 723 716 -7
Continue to review full report at Codecov.
|
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For classification problems, an error is thrown if the outcome is not a factor:
There are a lot of travis related changes too:
To get travis to run tests, the modeling packages have to be formal dependencies so a bunch were added to Suggests. This may be temporary; I may decide to remove these for the version sent to CRAN.
rstanarmwas excluded because compiling it (and its dependencies) exceeded the time allowed by travis.A variety of changes were made to the tests related to r-devel. It looks like any function directly accessed in the tests now need to be formal dependencies (not the case before). There is still some weirdness about this though and I've attributed it to being devel. Hopefully this will get smoothed out.