REF test_control to helper-objects #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patr1ckm
commented
Nov 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
======================================
Coverage 76.3% 76.3%
======================================
Files 38 38
Lines 2996 2996
======================================
Hits 2286 2286
Misses 710 710Continue to review full report at Codecov.
|
Member
|
Thanks |
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick refactor to move control objects in tests to a single file,
helper-objects.Ras suggested in #88. This was relatively standard across tests, with exceptions for stan which needed less verbosity.This is the easiest refactor suggested in the issue to be sure, but I'd like to handle the refactor of data references separately in smaller chunks. There's a bit of variability that will take some work to standardize, but I think it could be nice to have.