Skip to content

Conversation

@mdancho84
Copy link
Contributor

Hey @topepo et al,
Here is the work-in-progress version of the gen_additive_mod() function. I'm OK with changing anything, I'd just like to see GAM's get into parsnip.

@topepo
Copy link
Member

topepo commented Jun 11, 2021

Thanks for send this in.

Do we want to have gam as an engine? They frequently update the package to the most recent version of R and make breaking changes (without much developer sympathy/consideration). At the minimum, I'd like to make the default engine mgcv.

We're almost done with a new documentation system for parsnip and I've adjusted the doc file (incompletely) to prepare for this. (I'll do a modeltime PR to show how it is done; it is opt-in).

@mdancho84
Copy link
Contributor Author

Thanks for send this in.

Do we want to have gam as an engine? They frequently update the package to the most recent version of R and make breaking changes (without much developer sympathy/consideration). At the minimum, I'd like to make the default engine mgcv.

We're almost done with a new documentation system for parsnip and I've adjusted the doc file (incompletely) to prepare for this. (I'll do a modeltime PR to show how it is done; it is opt-in).

Hey, I'll leave this one up to you. mgcv::gam() is the function that is being used, so maybe mgcv is fine.

@topepo topepo requested a review from hfrick June 15, 2021 00:36
topepo added a commit to tidymodels/dials that referenced this pull request Jun 15, 2021
@topepo topepo merged commit 255b67e into tidymodels:master Jun 16, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants