case weights #692
Merged
case weights #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
All models with case weights will be tested in extratests. Spark support is still outstanding because there are some API issues to work out. Sparks models want a column name for the weights argument. |
Member
DavisVaughan
left a comment
DavisVaughan
left a comment
There was a problem hiding this comment.
Looking pretty good so far!
Co-authored-by: Davis Vaughan <davis@rstudio.com>
…705) * Prefix everywhere we use `new_quosure()` or `empty_env()` We don't import these, so we have to do this. Tests were only working by chance because we have `library(rlang)` in some of the test files! * Ensure that `fit_xy()` patches the formula environment with weights * missing roxygen tag * avoid deprecated tests Co-authored-by: Max Kuhn <mxkuhn@gmail.com>
Member
|
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136