Skip to content

fix formatting in prompt_missing_implementation() #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022
Merged

fix formatting in prompt_missing_implementation() #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a723680
fix formatting in `prompt_missing_implementation()`
simonpcouch Sep 8, 2022
09d6b72
Merge branch 'main' into fix-glue-msg
topepo Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/misc.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ prompt_missing_implementation <- function(spec,
msg <- c(
"!" = "{.pkg parsnip} could not locate an implementation for `{cls}` {mode} \\
model specifications{if (isTRUE(user_specified_engine)) {
' using the `{engine}` engine' } else {''}}."
paste0(' using the `', engine, '` engine')} else {''}}."
)

if (nrow(avail) == 0 && nrow(all) > 0) {
Expand Down
7 changes: 7 additions & 0 deletions tests/testthat/_snaps/fit_interfaces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,10 @@
i Please install (if needed) and load to continue.


---

! parsnip could not locate an implementation for `cubist_rules` model specifications using the `Cubist` engine.
i The parsnip extension package rules implements support for this specification.
i Please install (if needed) and load to continue.


1 change: 1 addition & 0 deletions tests/testthat/test_fit_interfaces.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,4 +109,5 @@ test_that('No loaded engines', {
)
expect_snapshot_error({cubist_rules() %>% fit(mpg ~., data = mtcars)})
expect_snapshot_error({poisson_reg() %>% fit(mpg ~., data = mtcars)})
expect_snapshot_error({cubist_rules(engine = "Cubist") %>% fit(mpg ~., data = mtcars)})
})