Skip to content

Conversation

@hfrick
Copy link
Member

@hfrick hfrick commented Dec 22, 2022

We generally try to put tests on the basic model function (like poisson_reg()) in parsnip since the model definitions now live here. This PR moves some of those tests from poissonreg to here.

The corresponding PR to remove them from poissonreg is: tidymodels/poissonreg#55

Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

})

test_that("bad input", {
expect_snapshot(error = TRUE, poisson_reg(mode = "bogus"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mode = "bogus"😆

@hfrick hfrick merged commit 0b6b85f into main Jan 3, 2023
@hfrick hfrick deleted the test-poisson_reg branch January 3, 2023 11:58
@github-actions
Copy link
Contributor

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants