-
Notifications
You must be signed in to change notification settings - Fork 106
Quosured argument changes #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## quosure-passthrough #94 +/- ##
======================================================
Coverage ? 72.55%
======================================================
Files ? 30
Lines ? 2190
Branches ? 0
======================================================
Hits ? 1589
Misses ? 601
Partials ? 0
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Tests are updated for the new approach of capturing arguments as quosures as well as the removal of
others().Instead of creating a new, clean environment, we go back to creating a child of the current environment. The clean environment had issues with some packages not importing (or calling by namespace) functions from
statssuch asmodel.frame.Fixed
glmnetprediction issues. The predict method formodel_fituses the model specification to get thelambdato predictive with. In this branch, all arguments are quosures so this fails. Theglmnet-specific predict method evaluate the specification arguments before predicting.varying_args()now works for complex arguments such assampsize = c(12, varying()).Model wrappers for C5.0, keras, and xgboost are documented.