Skip to content

Conversation

@topepo
Copy link
Member

@topepo topepo commented Oct 18, 2018

  • Tests are updated for the new approach of capturing arguments as quosures as well as the removal of others().

  • Instead of creating a new, clean environment, we go back to creating a child of the current environment. The clean environment had issues with some packages not importing (or calling by namespace) functions from stats such as model.frame.

  • Fixed glmnet prediction issues. The predict method for model_fit uses the model specification to get the lambda to predictive with. In this branch, all arguments are quosures so this fails. The glmnet-specific predict method evaluate the specification arguments before predicting.

  • varying_args() now works for complex arguments such as sampsize = c(12, varying()).

  • Model wrappers for C5.0, keras, and xgboost are documented.

@codecov-io
Copy link

codecov-io commented Oct 18, 2018

Codecov Report

❗ No coverage uploaded for pull request base (quosure-passthrough@59f0c66). Click here to learn what that means.
The diff coverage is 87.23%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             quosure-passthrough      #94   +/-   ##
======================================================
  Coverage                       ?   72.55%           
======================================================
  Files                          ?       30           
  Lines                          ?     2190           
  Branches                       ?        0           
======================================================
  Hits                           ?     1589           
  Misses                         ?      601           
  Partials                       ?        0
Impacted Files Coverage Δ
R/boost_tree.R 83.58% <ø> (ø)
R/mlp_data.R 78.94% <ø> (ø)
R/fit.R 79.11% <100%> (ø)
R/surv_reg.R 84% <100%> (ø)
R/linear_reg.R 75.86% <100%> (ø)
R/logistic_reg.R 67.56% <100%> (ø)
R/multinom_reg.R 78.74% <71.42%> (ø)
R/arguments.R 64.06% <85.71%> (ø)
R/varying.R 89.85% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f0c66...1c6d633. Read the comment docs.

@topepo topepo merged commit 882c192 into quosure-passthrough Oct 18, 2018
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants