Deprecate the options argument that is passed on to pROC#296
Merged
DavisVaughan merged 3 commits intomainfrom Apr 16, 2022
Merged
Deprecate the options argument that is passed on to pROC#296DavisVaughan merged 3 commits intomainfrom
options argument that is passed on to pROC#296DavisVaughan merged 3 commits intomainfrom
Conversation
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation of a switch to a custom roc-curve implementation that supports case weights.
It will no longer support any of the
optionspassed on to pROC, so we have to deprecate that argument. It was present in:roc_curve()roc_auc()roc_aunp()roc_aunu()metrics()Also contains a little cleanup of the pr-curve internals. Extracted
binary_threshold_curve()for use in roc-curve.