Visual tests about scale_date should not be locale-dependent

[yutannihilation]

They fail on my locale and it seems because the datetime labels are locale-dependent (e.g. May vs 5). This has been a headache for me for months and I tried to fix this several times, but don't find the solution yet... Since it seems only me who suffers from this, I think it's my role to fix this issue, but let me just file this here.

> devtools::test_file("tests/testthat/test-scale_date.R")
Loading ggplot2
Testing ggplot2
√ |  OK F W S | Context
x |   0 8     | scale_date [8.8 s]
--------------------------------------------------------------------------------
test-scale_date.R:15: failure: date scale draws correctly
Figures don't match: dates-along-x-default-breaks.svg


test-scale_date.R:18: failure: date scale draws correctly
Figures don't match: scale-x-date-breaks-date-breaks-2-weeks.svg


test-scale_date.R:21: failure: date scale draws correctly
Figures don't match: scale-x-date-breaks-3-weeks.svg


test-scale_date.R:24: failure: date scale draws correctly
Figures don't match: scale-x-date-labels-date-format-m-d.svg


test-scale_date.R:27: failure: date scale draws correctly
Figures don't match: scale-x-date-labels-date-format-w-week.svg


test-scale_date.R:32: failure: date scale draws correctly
Figures don't match: dates-along-y-default-breaks.svg


test-scale_date.R:33: failure: date scale draws correctly
Figures don't match: scale-y-date-breaks-date-breaks-2-weeks.svg


test-scale_date.R:36: failure: date scale draws correctly
Figures don't match: scale-y-date-breaks-3-weeks.svg

--------------------------------------------------------------------------------

== Results =====================================================================
Duration: 8.9 s

OK:       0
Failed:   8
Warnings: 0
Skipped:  0

[paleolimbot]

Possibly related, I get slightly different results for the sec-axis date scale (capital AM/PM vs am/pm).

> devtools::test_file("tests/testthat/test-sec-axis.R")
Loading ggplot2
Testing ggplot2
✔ |  OK F W S | Context
✖ |  28 1     | sec-axis [2.6 s]
───────────────────────────────────
test-sec-axis.R:285: failure: sec_axis works with date/time/datetime scales
Figures don't match: sec-axis-datetime-scale.svg

───────────────────────────────────

══ Results ══════════════════════════════════════════
Duration: 2.6 s

OK:       28
Failed:   1
Warnings: 0
Skipped:  0

[yutannihilation]

Oh, this test also fails on my laptop as well. Glad to know I'm not the only one...

[lionel-]

Interestingly I can reproduce the failures even though my locale is UTF-8.

Sys.getlocale()
#> [1] "en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8"

[yutannihilation]

Hmm, that's weird... Do you use R 3.6? With R <=3.5, the tests fail because of the different rng. (c.f. #3280)

[lionel-]

ah that must be it!

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/