Don't bother subsetting labels #6745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@teunbrand Hi Teun, I should have known better long ago when I wrote 'ggpp' than to piggy-back on the |
Contributor
|
Some visual tests in 'ggpp' were failing, but the OLD references were wrong, not the current output with the 'ggplot2' rc/4.0.1. So, the failures were incomsequential. I committed the new snaps and pushed them to GitHub. |
teunbrand
added a commit
that referenced
this pull request
Nov 14, 2025
* polish news * reorder a few bullets in news * prep for release * don't bother subsetting labels (#6745) * Increment version number to 4.0.1 * Increment version number to 4.0.1.9000 --------- Co-authored-by: Teun van den Brand <tahvdbrand@gmail.com> Co-authored-by: Teun van den Brand <49372158+teunbrand@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour removed here was discussed in #3740 (comment).
It was added just to be sure specifically for scale labels. Howveer, it is a hindrance as a global behaviour because people have wild inputs for the
labelaesthetic. I think the best solution here is to just drop this defensive behaviour and let people deal with bad input themselves.