Skip to content

Avoid undesired partial matching in glue() #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimhester merged 3 commits into from
Apr 14, 2017
Merged

Avoid undesired partial matching in glue() #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8a7d8c
Avoid undesired partial matching of .x argument
egnha Mar 30, 2017
5b15ccf
Adding NEWS from upstream
egnha Mar 30, 2017
dc81929
Add bug fix entry
egnha Mar 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# glue 0.0.0.9000

* Fix `glue()` to admit `.` as an embedded expression in a string (#15, @egnha).

* Added a `NEWS.md` file to track changes to the package.
2 changes: 1 addition & 1 deletion R/glue.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ to_data <- glue_data
#' @export
#' @rdname glue
glue <- function(..., .sep = "", .envir = parent.frame()) {
glue_data(NULL, ..., .sep = .sep, .envir = .envir)
glue_data(.x = NULL, ..., .sep = .sep, .envir = .envir)
}

#' @rdname glue
Expand Down
11 changes: 8 additions & 3 deletions tests/testthat/test-glue.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,16 @@ test_that("glue works with large outputs", {
test_that("glue works with named arguments", {
name <- "Fred"
res <- glue('My name is {name},',
' my age next year is {age + 1}',
' my age next year is {age + 1},',
' a dot is a {.}',
name = "Joe",
age = 40)
age = 40,
. = "'.'")

expect_identical(as_glue("My name is Joe, my age next year is 41"), res)
expect_identical(
as_glue("My name is Joe, my age next year is 41, a dot is a '.'"),
res
)

expect_identical("Fred", name)
})
Expand Down